On Tue, Jan 17, 2017 at 12:47:30AM -0800, Joe Perches wrote: > On Tue, 2017-01-17 at 11:27 +0300, Dan Carpenter wrote: > > On Tue, Jan 17, 2017 at 09:11:28AM +0100, Dhananjay Balan wrote: > > > Split line at boolean operator. > > > > > > Error was reported by checkpatch.pl as > > > WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data' > [] > > > diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > [] > > > @@ -94,8 +94,8 @@ int __init its_fsl_mc_msi_init(void) > > > continue; > > > } > > > > > > - WARN_ON(mc_msi_domain-> > > > - host_data != &its_fsl_mc_msi_domain_info); > > > + WARN_ON(mc_msi_domain->host_data != > > > + &its_fsl_mc_msi_domain_info); > > > > Better to line it up like this: > > > > WARN_ON(mc_msi_domain->host_data != > > &its_fsl_mc_msi_domain_info); > > At 81 chars, it might be better on a single line instead. > Yeah. Except you can't fight checkpatch.pl... In the long run it will just wear you down for no good reason. > WARN_ON(mc_msi_domain->host_data != &its_fsl_mc_msi_domain_info); > > It also might be better to shorten some of the identifiers. Yeah. Shorter names are a great idea. This driver went a bit crazy with all the prefixes. It's a static variable. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
