On Jan 15, 2017, at 3:14 AM, Dan Carpenter wrote: > "svcpt->scp_hist_seq" is a u64 so static checkers complain that 1U > should be 1ULL. I looked at REQS_SEQ_SHIFT() a little and it seems to > be capped by the number of CPUs online and the amount of memory, but I > think it could go above 32 possibly. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Reviewed-by: Oleg Drokin <oleg.drokin@xxxxxxxxx> > --- > I have not tested this change. > > diff --git a/drivers/staging/lustre/lustre/ptlrpc/events.c b/drivers/staging/lustre/lustre/ptlrpc/events.c > index 49f3e63..ae1650d 100644 > --- a/drivers/staging/lustre/lustre/ptlrpc/events.c > +++ b/drivers/staging/lustre/lustre/ptlrpc/events.c > @@ -277,7 +277,7 @@ static void ptlrpc_req_add_history(struct ptlrpc_service_part *svcpt, > * then we hope there will be less RPCs per bucket at some > * point, and sequence will catch up again > */ > - svcpt->scp_hist_seq += (1U << REQS_SEQ_SHIFT(svcpt)); > + svcpt->scp_hist_seq += (1ULL << REQS_SEQ_SHIFT(svcpt)); > new_seq = svcpt->scp_hist_seq; > } > > _______________________________________________ > lustre-devel mailing list > lustre-devel@xxxxxxxxxxxxxxxx > http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
