On Fri, Jan 06, 2017 at 08:43:57PM +1300, Derek Robson wrote:
> Changed permissions to be in octal style.
> Found by checkpatch.
>
> Signed-off-by: Derek Robson <robsonde@xxxxxxxxx>
> ---
>
> This version of patch also make the file type part of the mask with the permissions, as per recommendation from Greg K-H
>
> drivers/staging/greybus/camera.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> index 0ee291ca2c72..73ddb612953b 100644
> --- a/drivers/staging/greybus/camera.c
> +++ b/drivers/staging/greybus/camera.c
> @@ -1067,22 +1067,22 @@ struct gb_camera_debugfs_entry {
> static const struct gb_camera_debugfs_entry gb_camera_debugfs_entries[] = {
> {
> .name = "capabilities",
> - .mask = S_IFREG | S_IRUGO,
> + .mask = 0100444,
This is not readable at all. Octal numbers make sense for the
permissions bits, but not for the rest.
We have code that mix symbolic macros for the higher bits and octal
permissions, please do so here too.
Thanks,
Johan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
