On Fri, Jan 06, 2017 at 02:20:23PM +1300, Derek Robson wrote:
> Changed permissions to be in octal style.
> Found by checkpatch.
>
> Signed-off-by: Derek Robson <robsonde@xxxxxxxxx>
> ---
> drivers/staging/greybus/camera.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> index 0ee291ca2c72..a64517eabff4 100644
> --- a/drivers/staging/greybus/camera.c
> +++ b/drivers/staging/greybus/camera.c
> @@ -1067,22 +1067,22 @@ struct gb_camera_debugfs_entry {
> static const struct gb_camera_debugfs_entry gb_camera_debugfs_entries[] = {
> {
> .name = "capabilities",
> - .mask = S_IFREG | S_IRUGO,
> + .mask = S_IFREG | 0444,
So close, yet not correct :(
Please fix all of the permissions, not just one of them, unless you are
wanting to get two patches in instead of one here?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
