I've had these clean-up patches for the daqboard2000 driver sitting around for a few months, with a view to adding support for more boards in the same series, and adding support for extra subdevice types. I never got around to doing that, but I did manage to add support for a couple of extra DAC channels on one of the two currently supported card types. 01) staging: comedi: daqboard2000: use macros from "plx9080.h" 02) staging: comedi: daqboard2000: define macros for CPLD registers 03) staging: comedi: daqboard2000: use type 'u16' for CPLD data and status 04) staging: comedi: daqboard2000: check firmware length 05) staging: comedi: daqboard2000: replace daqboard2000_poll_cpld() 06) staging: comedi: daqboard2000: change daqboard2000_write_cpld() return value 07) staging: comedi: daqboard2000: check result of FPGA programming 08) staging: comedi: daqboard2000: check CPLD status before writing firmware data 09) staging: comedi: daqboard2000: remove unused 'card' member 10) staging: comedi: daqboard2000: use shorter, consistent prefix 11) staging: comedi: daqboard2000: use designated initializers 12) staging: comedi: daqboard2000: support 4 AO channels 13) staging: comedi: daqboard2000: change COMEDI device names 14) staging: comedi: daqboard2000: use pci_id_table 'driver_data' Note that there is a checkpatch warning in patches 07 and 08: "Possible unwrapped commit description (prefer a maximum 75 chars per line)", but that is due to a long URL in the patch description. drivers/staging/comedi/drivers/daqboard2000.c | 401 ++++++++++++++------------ 1 file changed, 222 insertions(+), 179 deletions(-) _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel