> -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Tuesday, January 03, 2017 10:48 AM > To: Stuart Yoder <stuart.yoder@xxxxxxx> > Cc: devel@xxxxxxxxxxxxxxxxxxxx; arnd@xxxxxxxx; Roy Pledge <roy.pledge@xxxxxxx>; Alexandru Marginean > <alexandru.marginean@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; agraf@xxxxxxx; Bogdan Hamciuc > <bogdan.hamciuc@xxxxxxx>; Laurentiu Tudor <laurentiu.tudor@xxxxxxx> > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > On Tue, Dec 06, 2016 at 06:10:38PM +0000, Stuart Yoder wrote: > > > > > > > -----Original Message----- > > > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > > Sent: Tuesday, December 06, 2016 11:56 AM > > > To: Stuart Yoder <stuart.yoder@xxxxxxx> > > > Cc: Ruxandra Ioana Radulescu <ruxandra.radulescu@xxxxxxx>; devel@xxxxxxxxxxxxxxxxxxxx; linux- > > > kernel@xxxxxxxxxxxxxxx; agraf@xxxxxxx; arnd@xxxxxxxx; Alexandru Marginean > <alexandru.marginean@xxxxxxx>; > > > Bogdan Hamciuc <bogdan.hamciuc@xxxxxxx>; Roy Pledge <roy.pledge@xxxxxxx>; Laurentiu Tudor > > > <laurentiu.tudor@xxxxxxx> > > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > > > > > On Tue, Dec 06, 2016 at 12:59:59PM +0000, Stuart Yoder wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > > > > Sent: Tuesday, December 06, 2016 4:20 AM > > > > > To: Ruxandra Ioana Radulescu <ruxandra.radulescu@xxxxxxx> > > > > > Cc: devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; agraf@xxxxxxx; arnd@xxxxxxxx; > > > Alexandru > > > > > Marginean <alexandru.marginean@xxxxxxx>; Bogdan Hamciuc <bogdan.hamciuc@xxxxxxx>; Stuart Yoder > > > > > <stuart.yoder@xxxxxxx>; Roy Pledge <roy.pledge@xxxxxxx>; Laurentiu Tudor > <laurentiu.tudor@xxxxxxx> > > > > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > > > > > > > > > On Tue, Dec 06, 2016 at 10:06:25AM +0000, Ruxandra Ioana Radulescu wrote: > > > > > > > -----Original Message----- > > > > > > > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > > > > > > Sent: Tuesday, December 06, 2016 11:58 AM > > > > > > > To: Ruxandra Ioana Radulescu <ruxandra.radulescu@xxxxxxx> > > > > > > > Cc: devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > > > > > > > agraf@xxxxxxx; arnd@xxxxxxxx; Alexandru Marginean > > > > > > > <alexandru.marginean@xxxxxxx>; Bogdan Hamciuc > > > > > > > <bogdan.hamciuc@xxxxxxx>; Stuart Yoder <stuart.yoder@xxxxxxx>; Roy > > > > > > > Pledge <roy.pledge@xxxxxxx>; Laurentiu Tudor > > > > > > > <laurentiu.tudor@xxxxxxx> > > > > > > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > > > > > > > > > > > > > On Tue, Dec 06, 2016 at 03:34:41AM -0600, Ioana Radulescu wrote: > > > > > > > > Add a list of TODO items for the Ethernet driver > > > > > > > > > > > > > > > > Signed-off-by: Ioana Radulescu <ruxandra.radulescu@xxxxxxx> > > > > > > > > --- > > > > > > > > drivers/staging/fsl-dpaa2/ethernet/TODO | 9 +++++++++ > > > > > > > > 1 files changed, 9 insertions(+), 0 deletions(-) > > > > > > > > create mode 100644 drivers/staging/fsl-dpaa2/ethernet/TODO > > > > > > > > > > > > > > > > diff --git a/drivers/staging/fsl-dpaa2/ethernet/TODO b/drivers/staging/fsl- > > > > > > > dpaa2/ethernet/TODO > > > > > > > > new file mode 100644 > > > > > > > > index 0000000..833265b > > > > > > > > --- /dev/null > > > > > > > > +++ b/drivers/staging/fsl-dpaa2/ethernet/TODO > > > > > > > > @@ -0,0 +1,9 @@ > > > > > > > > +* Add a DPAA2 MAC kernel driver in order to allow PHY management; > > > > > > > currently > > > > > > > > + the DPMAC objects and their link to DPNIs are handled by MC internally > > > > > > > > + and all PHYs are seen as fixed-link > > > > > > > > +* add more debug support: decide how to expose detailed debug > > > > > > > statistics, > > > > > > > > + add ingress error queue support > > > > > > > > +* MC firmware uprev; the DPAA2 objects used by the Ethernet driver > > > > > > > need to > > > > > > > > + be kept in sync with binary interface changes in MC > > > > > > > > +* refine README file > > > > > > > > +* cleanup > > > > > > > > > > > > > > These seem like very minor things, why not just spend a week and do this > > > > > > > work and get it merged to the "correct" portion of the kernel tree? Why > > > > > > > does this have to go into staging? > > > > > > > > > > > > Actually the first bullet is not minor at all and requires some design > > > > > > choices that we aren't yet completely clear with, and which in turn may > > > > > > affect parts of the Ethernet driver. We figured it would be best to try > > > > > > adding this in staging first (and also provide this way an example of using > > > > > > the fsl-mc bus and dpio driver) than wait until all MAC development > > > > > > questions are ironed-out. > > > > > > > > > > Ok, that makes sense. > > > > > > > > > > > I can remove the other bullets from the TODO list if you think they're > > > > > > not worth mentioning. > > > > > > > > > > No, they should be mentioned, I just didn't think they are all that much > > > > > work, and if you didn't have major things needed to get done, you could > > > > > just knock it all out in a week of local development. > > > > > > > > > > I'll look into taking this into the tree later today... > > > > > > > > Note, as mentioned in the cover letter, in it's current form this patch > > > > series is based on the series: > > > > [PATCH v3 0/9] staging: fsl-mc: move bus driver out of staging, add dpio > > > > > > > > ...which means that it won't build or run without that series being > > > > applied first, due to header file dependencies. It also functionally > > > > depends on the DPIO driver. So we need the dpio driver merged first. > > > > > > > > Is moving the fsl-mc bus driver out of staging a possibility now? > > > > > > I'm ok with it, but I really haven't looked at the patches in a while, I > > > keep seeing others have problems with it. Want me to review it now? > > > > Yes, would like that very much. > > Ok, basic driver model things, who is cleaning up your struct devices > when they go away? Don't you get nasty warnings from the driver core > when the device is removed? Thanks, you had some similar comments back in December: https://lkml.org/lkml/2016/12/8/364 Device removal works, but we are not getting warnings because the ref count never goes to zero...so something is wrong and we are debugging and will refactoring. > And you can't allocate a 'struct device' with devm_kzalloc(), that's > just crazy as the lifetime can not be owned by someone else for a > refernce counted object! > > And finally, no one is calling dpmcp_destroy(), why is it there? Looks not to be needed...will that and any other functions that are not called. > I think this needs a lot of driver model rework, sorry. Please do that > before adding new drivers. Yes, work is in progress. Thanks, Stuart _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
