On Mon, Dec 19, 2016 at 07:44:42PM +0200, Ozgur Karatas wrote: > 19.12.2016, 08:35, "Greg KH" <gregkh@xxxxxxxxxxxxxxxxxxx>: > > On Sun, Dec 18, 2016 at 11:47:30AM -0600, Scott Matheina wrote: > >> These changes where identified by checkpatch.pl as needed changes to > >> align the code with the linux development coding style. The several > >> lines of text where aligned with the precending parenthesis. > >> > >> Signed-off-by: Scott Matheina <scott@xxxxxxxxxxxx> > >> > >> Changes to be committed: > >> modified: drivers/staging/fbtft/fb_agm1264k-fl.c > > > > Why are these lines in the changelog text? > > I checked with checkpatch script to code and give a some errors. > So, the code have to "udelay(20)". > > udelay(20); > > I read to Documentation/timers/timers-howto.txt and > this line incorrect, usleep_range need must be add defined U_DELAY and fixed. > > udelay(U_DELAY, U_DELAY + 10); > > finally: > > $ checkpatch.pl drivers/staging/fbtft/fb_agm1264k-fl.c | grep total > total: 0 errors > > Signed-off-by: Ozgur Karatas <okaratas@xxxxxxxxxxxxxx> > > --- > drivers/staging/fbtft/fb_agm1264k-fl.c | 31 ++++++++++++------------------- > 1 file changed, 12 insertions(+), 19 deletions(-) You do realize there's nothing I can do with this patch as-is, right? Please fix up the changelog text and resend it properly if you wish to have it included. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
