On 12/30/2016 08:59 PM, Jonathan Cameron wrote: > On 11/12/16 02:47, Eva Rachel Retuya wrote: >> Eliminate the non-standard attributes in_voltage_range and >> in_voltage_range_available. Implement in_voltage_scale_available in place >> of these attributes and update the SCALE accordingly. The array >> scale_avail is introduced to hold the available scale values. >> >> Signed-off-by: Eva Rachel Retuya <eraretuya@xxxxxxxxx> > Looks good to me. > > Lars, if you have a minute to look over this as well that would > be great. I think this is OK as is, since it is an improvement over the current situation. But there is still the open issue that we don't know the scale setting if pin is hardwired. I'd like to see that addressed before the driver is moved out of staging. Similar for the oversampling ratio. Consider this Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx> _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
