Re: [PATCH v2 1/5] staging: greybus: operation: add asynchronous gb_operation_cancel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 27, 2016 at 01:01:35PM +0000, Bryan O'Donoghue wrote:
> Later patches don't want or need to serialize the cancellation of an
> operation. This patch adds gb_operation_cancel_async() as a simple subset
> of the existing gb_operation_cancel() sans the synchronous wait on the
> cancellation queue.

This one is not needed and complicates the interface for no good reason
(the async suffix also falsely indicates that this function could be
called from atomic context).

Just cancel synchronously in the delayed worker function you add later
in the series.

Johan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux