On 23/12/16 18:51, Thomas Preisner wrote: > At the end of function ad7150_write_event_config(), "return 0" seems > improper. It may be better to return the value of ret. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188871 > > Reported-by: Pan Bian <bianpan2016@xxxxxxx> > Signed-off-by: Thomas Preisner <thomas.preisner+linux@xxxxxx> > Signed-off-by: Milan Stephan <milan.stephan+linux@xxxxxx> I already see a patch for this from Pan. Jonathan > --- > drivers/staging/iio/cdc/ad7150.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c > index 6998c3d..04861eb 100644 > --- a/drivers/staging/iio/cdc/ad7150.c > +++ b/drivers/staging/iio/cdc/ad7150.c > @@ -274,7 +274,7 @@ static int ad7150_write_event_config(struct iio_dev *indio_dev, > error_ret: > mutex_unlock(&chip->state_lock); > > - return 0; > + return ret; > } > > static int ad7150_read_event_value(struct iio_dev *indio_dev, > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
