On 25 December 2016 20:14:09 GMT+00:00, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: >On Sun, Dec 25, 2016 at 01:41:06PM -0600, Scott Matheina wrote: >> Across the file, variables were sometimes upper case, some times >> lower case, this fix addresses a few of the instances with this >> inconsistency. > >NAK. Go learn C and don't come back until you've done that. If >somebody >has told you that you can contribute without knowing the language, >they'd >lied - you really can't. And I would *STRONGLY* recommend to stay away >from drivers/staging while you are learning C - it's like trying to use >a public restroom wall as a sex-ed textbook. Please can we keep things polite. Jonathan > >While we are at it, it might be a good idea to check if the kernel >builds after your changes and see what errors are produced. -- Sent from my Android device with K-9 Mail. Please excuse my brevity. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
