On 19/12/2016 15:14, devendra sharma wrote:
Fixed coding issue about multiple line dereferencing Signed-off-by: Devendra Sharma <devendra.sharma9091@xxxxxxxxx> --- drivers/staging/comedi/drivers/cb_pcidas64.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)
I guess this is version 3 of the patch?
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c index cb9c269..9ace9c0 100644 --- a/drivers/staging/comedi/drivers/cb_pcidas64.c +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c @@ -2475,20 +2475,17 @@ static int setup_channel_queue(struct comedi_device *dev, /* load external queue */ for (i = 0; i < cmd->chanlist_len; i++) { bits = 0; + unsigned int ch = cmd->chanlist[i];
Please put all declarations within a block before any statements in the block (in other words, avoid mixing declarations with code), and use a blank line to separate the declarations from the statements.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Web: http://www.mev.co.uk/ )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel