On Fri, 2016-12-16 at 23:29 +0530, Tabrez khan wrote:
> Remove unnecessary braces {} from single line if statement.
> This warning is found using checkpatch.pl.
[]
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/import.c b/drivers/staging/lustre/lustre/ptlrpc/import.c
[]
> @@ -1134,9 +1134,9 @@ static int ptlrpc_connect_interpret(const struct lu_env *env,
> }
>
> /* Sanity checks for a reconnected import. */
> - if (!(imp->imp_replayable) != !(msg_flags & MSG_CONNECT_REPLAYABLE)) {
> + if (!(imp->imp_replayable) != !(msg_flags & MSG_CONNECT_REPLAYABLE))
> CERROR("imp_replayable flag does not match server after reconnect. We should LBUG right here.\n");
> - }
> +
There are one too many blank lines now.
And that's an awful lot of !s.
Generically, it might make simpler reading code to
cast to bool instead of using !.
Most code uses !! to make sure whatever value is
either 0 or 1 without changing the logic/polarity.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
