Re: staging: comedi: usbduxsigma: Split a condition check in usbduxsigma_alloc_usb_buffers()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/12/16 15:46, SF Markus Elfring wrote:
* Reduce memory allocation sizes for two function calls.

Is this implementation detail worth for further considerations?

I assume you are referring to the allocation of devpriv->ai_urbs and devpriv->ao_urbs? Your patch does not reduce their sizes; `urb` and `*devpriv->ai_urbs` have the same type `struct urb *`. Having said that, `sizeof(*devpriv->ai_urbs)` is cleaner code than `sizeof(urb)` in this case.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux