Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote:
> For the first lines of the patch, I opted to create a small function
> instead of breaking the the line in a weird way.

These first ones are the nice.

> @@ -2511,13 +2516,15 @@ static int dgnc_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
>  				if (ch->ch_tun.un_flags & (UN_LOW | UN_EMPTY)) {
>  					ch->ch_tun.un_flags &=
>  						~(UN_LOW | UN_EMPTY);
> -					wake_up_interruptible(&ch->ch_tun.un_flags_wait);
> +					wake_up_interruptible(&ch->ch_tun
> +							.un_flags_wait);


Ugh...  No.  Don't do this.  Just let it go over 80 characters.  Ignore
the warning.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux