On 03/12/16 13:44, Pan Bian wrote: > From: Pan Bian <bianpan2016@xxxxxxx> > > At the end of function ad7150_write_event_config(), directly returns 0. > As a result, the errors will be ignored by the callers. It may be better > to return variable "ret". > > Signed-off-by: Pan Bian <bianpan2016@xxxxxxx> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/staging/iio/cdc/ad7150.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c > index 5578a07..50a5b0c2 100644 > --- a/drivers/staging/iio/cdc/ad7150.c > +++ b/drivers/staging/iio/cdc/ad7150.c > @@ -274,7 +274,7 @@ static int ad7150_write_event_config(struct iio_dev *indio_dev, > error_ret: > mutex_unlock(&chip->state_lock); > > - return 0; > + return ret; > } > > static int ad7150_read_event_value(struct iio_dev *indio_dev, > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
