On 12/02/2016 11:09 AM, Yan Laijun wrote: > Fixed checkpatch warning "line over 80 characters" in > wlan-ng/hfa384x_usb.c file. > > Signed-off-by: Yan Laijun <yan.laijun@xxxxxxxxx> > --- > Changes in v2: > - Remove initialization of usbin on its decarlation. > --- > drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c > index 5f11f6e..c7bda04 100644 > --- a/drivers/staging/wlan-ng/hfa384x_usb.c > +++ b/drivers/staging/wlan-ng/hfa384x_usb.c > @@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb) > { > struct wlandevice *wlandev = urb->context; > struct hfa384x *hw; > - union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer; > + union hfa384x_usbin *usbin; > struct sk_buff *skb = NULL; > int result; > int urb_status; > @@ -3049,6 +3049,7 @@ static void hfa384x_usbin_callback(struct urb *urb) > ABORT > } action; > > + usbin = (union hfa384x_usbin *)urb->transfer_buffer; > if (!wlandev || !wlandev->netdev || wlandev->hwremoved) > goto exit; > > If you separate declaration and assignment of usbin, maybe it makes sense to move the assignment down to where usbin is used for the first time. Regards, Markus _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel