On Wed, Nov 30, 2016 at 01:15:50PM -0600, Alex Elder wrote: > On 11/30/2016 12:32 PM, Dan Carpenter wrote: > > On Wed, Nov 30, 2016 at 05:21:40PM +0100, Andrea Ghittino wrote: > >> Honestly, for a kernel newbie it is difficult to manage. I received 2 > >> email that suggest > >> to use S_IRUGO. My original patch was with octal, based on checkpatch.pl advice. > > Go ahead with the octal version. If Linus (and checkpatch) prefers > it that way, so be it. The "real" solution is to use the correct DEVICE_ATTR_RW() style macros, which have no octal or S_* usage in them at all, then no one can complain :) thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
