Re: [PATCH 1/3] staging: comedi: s626: use preferred kernel type u8

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 30, 2016 at 06:04:14PM +0330, Saber Rezvani wrote:
> @@ -1035,7 +1035,7 @@ static int s626_dio_set_irq(struct comedi_device *dev, unsigned int chan)
>  	return 0;
>  }
>  
> -static int s626_dio_reset_irq(struct comedi_device *dev, unsigned int group,
> +static int s626_dio_reset_irq(struct comedi_device *dev, u8 group,
>  			      unsigned int mask)
>  {
>  	/* disable edge capture write command */

This change isn't wrong, but it should be in a different patch or at the
very least mentioned in the changelog.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux