On Sat, 2016-11-26 at 22:50 +0100, Andrea Ghittino wrote: > Fixes greybus user/groups permission style warnings > found by checkpatch.pl tool > > Signed-off-by: Andrea Ghittino <aghittino at gmail.com> > --- > diff --git a/drivers/staging/greybus/camera.c > b/drivers/staging/greybus/camera.c > index 1c5b41a..4424f63 100644 > --- a/drivers/staging/greybus/camera.c > +++ b/drivers/staging/greybus/camera.c > @@ -1067,22 +1067,22 @@ struct gb_camera_debugfs_entry { > static const struct gb_camera_debugfs_entry > gb_camera_debugfs_entries[] = { > { > .name = "capabilities", > - .mask = S_IFREG | S_IRUGO, > + .mask = S_IFREG | 0444, I think the descriptive text makes way more sense than the magic number, especially moreso than the 80 character limit. --- bod _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel