On Sat, Nov 19, 2016 at 03:46:04PM +0000, Okash Khawaja wrote: > This does two things: > > 1. add serial_out() method to spk_synth > 2. replace calls to spk_serial_out() in spk_do_catch_up() and > spk_synth_flush() with calls to serial_out() > > spk_do_catch_up() and spk_synth_flush() are the only functions through > which speakup_dummy calls into spk_serial_out(). Calls to spk_serial_out() in > other drivers can stay for now. > > Signed-off-by: Okash Khawaja <okash.khawaja@xxxxxxxxx> Doesn't this patch break all drivers that do not have this set? You can't break things with a patch, please rework this series (and rename the function), to not do that. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
