Re: [PATCHv2]: staging: Greybus: Remove unnecessary braces for single statement block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 18, 2016 at 07:04:20PM +0530, Rahul Krishnan wrote:
> This patch fixes the following checkpath.pl warning
> WARNING: braces {} are not necessary for single statement blocks
> 
> Fixed indentation error, noted by Dan Carpenter
> 
> Signed-off-by: Rahul Krishnan <mrahul.krishnan@xxxxxxxxx>
> ---
>  drivers/staging/greybus/sdio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
> index f60b458..66b37ea 100644
> --- a/drivers/staging/greybus/sdio.c
> +++ b/drivers/staging/greybus/sdio.c
> @@ -192,7 +192,7 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
>  	}
>  
>  	if (event & GB_SDIO_WP)
> -	host->read_only = true;
> +		host->read_only = true;

You need to redo your original patch. This one instead looks like a
follow-up to your first revision (which actually removed the braces).

>  
>  	if (state_changed) {
>  		dev_info(mmc_dev(host->mmc), "card %s now event\n",

Thanks,
Johan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux