On Thu, Nov 10, 2016 at 07:16:39PM +0100, Sergio Paracuellos wrote: > +#define HFA384x_CMD_AINFO ((u16)GENMASK(14, 8)) The casts to u16 are pointless because of type promotion and half of these defines aren't used anyway (both that I looked at). regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel