On 12/11/16 18:19, Brian Masney wrote:
> If channel 0 does not have any data, then the code sets the lux to zero.
> The corresponding comment says that the last value is returned. This
> updates the comment to correctly reflect what the code does. It also
> clarifies the comment about why 0 is returned.
>
> Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx>
Applied.
> ---
> drivers/staging/iio/light/tsl2583.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
> index 52a39a6..dbb7f6a 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -221,7 +221,11 @@ static int tsl2583_get_lux(struct iio_dev *indio_dev)
> goto return_max;
>
> if (!ch0) {
> - /* have no data, so return LAST VALUE */
> + /*
> + * The sensor appears to be in total darkness so set the
> + * calculated lux to 0 and return early to avoid a division by
> + * zero below when calculating the ratio.
> + */
> ret = 0;
> chip->als_cur_info.lux = 0;
> goto done;
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
