Hi Michael, > Michael Zoran <mzoran@xxxxxxxxxxxx> hat am 11. November 2016 um 07:15 > geschrieben: > > > VCHIQ/vc04_services has a userland device interface > that includes ioctls. The current ioctl implementation > is a single monolithic function over 1,000+ lines > that handles 17 different ioctls through a complex > maze of switch and if statements. > > The change reimplements that code path by breaking > up the code into smaller, easier to maintain functions > and uses a dispatch table to invoke the correct function. nice. But please always use scripts/checkpatch.pl before submitting your patches. And yes it is not necessary to fix all "line over 80 chars" warnings. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
