Re: [PATCH v3 03/28] staging: iio: tsl2583: check if chip is suspended in in_illuminance_calibrate_store

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Nov 12, 2016 at 04:27:32PM +0000, Jonathan Cameron wrote:
> On 12/11/16 16:24, Jonathan Cameron wrote:
> > On 10/11/16 09:25, Brian Masney wrote:
> >> in_illuminance_calibrate_store() did not check to see if the chip is
> >> suspended. This patch adds the proper check. The return value from
> >> taos_als_calibrate() was also not checked in this function, so the
> >> proper check was also added while changes are being made here.
> >>
> >> Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx>
> > Applied.
> And backed out. It doesn't build :(
> 
> drivers/staging/iio/light/tsl2583.c:511:10: error: ‘struct tsl2583_chip’ has no member named ‘suspended’
>   if (chip->suspended) {
>           ^~

Bummer! I'll get this fixed and send out an updated series in a little
bit.

Brian
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux