PTR_ERR should access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Dmitry Torokhov <dtor@xxxxxxxxxxxx> Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> --- 0-day warning related to the following commit: tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing head: dfea747d2aba77443acf7ce6fa37caa729bd034c commit: 79543cf2b18ea4a35f8864849d7ad8882ea8a23d [10/14] driver-core: add test module for asynchronous probing I haven't checked the context in detail. test_async_driver_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/base/test/test_async_driver_probe.c +++ b/drivers/base/test/test_async_driver_probe.c @@ -119,7 +119,7 @@ static int __init test_async_probe_init( sync_dev_1 = platform_device_register_simple("test_sync_driver", 1, NULL, 0); if (IS_ERR(async_dev_1)) { - error = PTR_ERR(sync_dev_1); + error = PTR_ERR(async_dev_1); pr_err("failed to create sync_dev_1: %d", error); goto err_unregister_sync_driver; } _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel