The series addresses several different issues: 1. Fixes several issues discovered by Greg KH's code review: * Converts client_bus_info into a debugfs structure instead of using sysfs. * Refactors the code in the functions processing controlvm messages to avoid calling bus_epilog and device_epilog, as an intermediate step towards simplifying the controlvm processing so that it is clear that error codes produced in this code are in-fact being returned to the s-Par firmware, and NOT being ignored. Note that we are currently sending back to the s-Par Firmware a linux error code (e.g., -ENOMEM) when we should be sending back a ControlVM error code; a later series will address that. * In the process of doing this refactoring, error-handling was added to several of the controlvm-handling functions. 2. Address a problem where we were sending double responses back to the s-Par Firmware when processing CONTROLVM Messages. 3. Several misc formatting and style correction patches are included as well. David Binder (2): staging: unisys: visorbus: Adjust formatting of variable assignment staging: unisys: visorinput: Add default conditions to case statements David Kershner (10): staging: unisys: visorbus: fix double response staging: unisys: visorbus: bus_create no longer calls bus_epilog staging: unisys: visorbus: bus_destroy do not call bus_epilog staging: unisys: visorbus: bus_destroy add error handling staging: unisys: visorbus: bus_create fix error handling staging: unisys: visorbus: remove bus_epilog staging: unisys: visorbus: my_device_create does not call device_epilog staging: unisys: visorbus: my_device_changestate: add error response staging: unisys: visorbus: my_device_changestate: no longer call device_epilog staging: unisys: visorbus: in my_device_destroy don't call device_epilog Sameer Wadgaonkar (1): staging: unisys: visorbus: remove unused initializations Tim Sell (2): staging: unisys: visorbus: move DEVICE_ATTR_RO defs as-per conventions staging: unisys: visorbus: convert client_bus_info sysfs to debugfs drivers/staging/unisys/include/visorbus.h | 2 + drivers/staging/unisys/visorbus/vbuschannel.h | 214 ++------------- drivers/staging/unisys/visorbus/visorbus_main.c | 187 +++++++------ drivers/staging/unisys/visorbus/visorchipset.c | 348 ++++++++++++------------ drivers/staging/unisys/visorinput/visorinput.c | 6 + 5 files changed, 320 insertions(+), 437 deletions(-) -- 1.9.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel