Re: [PATCH v3] staging : rtl8712: Free memory when kmalloc fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



H Greg,

On Mon, Oct 31, 2016 at 3:37 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Oct 31, 2016 at 02:32:39PM +0530, Souptick Joarder wrote:
>> There are few functions where we need to free previously allocated
>> memory when kmalloc fails. Else it may lead to memory leakage. In
>> _init_cmd_priv() and _r8712_init_xmit_priv(), in few places we are
>> not freeing previously allocated memory when kmalloc fails.
>>
>> Signed-off-by: Souptick joarder <jrdr.linux@xxxxxxxxx>
>> ---
>> v2:
>>   - Make the commit message more descriptive
>> v3:
>>   - Modified the patch description by adding space in required places
>
> Why did you resend the broken v3 patch?

I am getting confused here. Do I need to update the change log again to v4?
The last patch which I send today is the latest patch file from my side.
I tried to apply it locally and it's working fine.

I am not clear what is the mistake I am doing ?
It will be helpful if you explain a bit that I will not repeat the
same mistake again.
>
> This is getting really annoying, what would you do in my situation?...

I am extremely sorry for causing this unnecessary overhead.
It was not intentional.  Sorry once again.

As this is really getting worse, Shall I drop this patch , rewrite
this patch and summit it as a completely new patch ?

Regards
Souptick
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux