Re: [PATCH 4/5] staging: vc04_services: fix CamelCase

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 27, 2016 at 04:24:31AM +0300, Dan Carpenter wrote:
> On Wed, Oct 26, 2016 at 06:13:13PM -0700, Eric Anholt wrote:
> > Stefan Wahren <stefan.wahren@xxxxxxxx> writes:
> > 
> > > This fixes the CamelCase of some variables.
> > >
> > > Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx>
> > 
> > Greg, are these kinds of reformats something that you're looking for in
> > the staging tree?  I'm fine with the patch but I didn't see camel case
> > explicitly called out in CodingStyle after a brief search.
> 
> Yeah.  checkpatch.pl complains and also they look like garbage.
> 
> I wrote a tool to help review these btw.  Just
> 	cat patch.txt | rename_rev.pl -a

$ cat ../s1 | perl ./rename_rev.pl
Can't use global $_ in "my" at ./rename_rev.pl line 53, near "my $_ "
Execution of ./rename_rev.pl aborted due to compilation errors.

:(
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux