Re: [PATCH] staging: greybus: es2: fix arpc request size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19-10-16, 13:44, Rui Miguel Silva wrote:
> Fix size field of arpc message request by using the header size and not
> the pointer size.
> 
> Signed-off-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx>
> ---
>  drivers/staging/greybus/es2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
> index 8eabc71..d7fd4a0 100644
> --- a/drivers/staging/greybus/es2.c
> +++ b/drivers/staging/greybus/es2.c
> @@ -1033,7 +1033,7 @@ static struct arpc *arpc_alloc(void *payload, u16 size, u8 type)
>  		goto err_free_req;
>  
>  	rpc->req->type = type;
> -	rpc->req->size = cpu_to_le16(sizeof(rpc->req) + size);
> +	rpc->req->size = cpu_to_le16(sizeof(*rpc->req) + size);
>  	memcpy(rpc->req->data, payload, size);
>  
>  	init_completion(&rpc->response_received);

Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

-- 
viresh
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux