Re: [PATCH] staging: rtl8188eu: os_dep: fix checkpatch issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 18, 2016 at 11:30:29PM +0200, Pierre-Yves Kerbrat wrote:
> This patch fixes the following:
> - fix 2 block comments
> - add missing spaces around operators
> - remove unnecessary kzalloc fail message
> - fix line over 80 char
> ...

When you find yourself listing all of the different things a single
patch does, that's a huge hint that you need to break it up into
multiple patches.

Each patch should only do one "logical" thing.  And no, "fix all
checkpatch issues" is not one logical thing :)

Please redo this as a patch series.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux