On Mon, Oct 17, 2016 at 03:21:52PM -0400, Ryan Swan wrote: > Fixed: sparse WARNING: symbol 'lov_read_and_clear_async_rc' was not declared. Should it be static? I don't believe you actually test-built this change :( > > Signed-off-by: Ryan Swan <ryan@xxxxxxxxxxxx> > --- > drivers/staging/lustre/lustre/lov/lov_object.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c > index 82b99e0..c42eef6 100644 > --- a/drivers/staging/lustre/lustre/lov/lov_object.c > +++ b/drivers/staging/lustre/lustre/lov/lov_object.c > @@ -1532,7 +1532,7 @@ struct lov_stripe_md *lov_lsm_addref(struct lov_object *lov) > return lsm; > } > > -int lov_read_and_clear_async_rc(struct cl_object *clob) > +static int lov_read_and_clear_async_rc(struct cl_object *clob) You are turning a symbol that is explicitly exported into a static one? How is the compiler supposed to figure out what to do when you do that? Again, always test-build your patches so you don't get a grumpy maintainer telling you to test-build your patches... greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
