On Mon, Oct 17, 2016 at 01:13:55AM +0530, Pankaj Bharadiya wrote:
> Replace CamelCase names with underscores to comply with the standard
> kernel coding style.
>
> Signed-off-by: Pankaj Bharadiya <pankaj.bharadiya@xxxxxxxxx>
> ---
> drivers/staging/dgnc/dgnc_tty.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index ef9a45b..1a21902 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -45,7 +45,7 @@
> /*
> * internal variables
> */
> -static unsigned char *dgnc_TmpWriteBuf;
> +static unsigned char *dgnc_tmp_write_buf;
Why not just fix the code to not have this variable at all? It's not
correct to have it from what I can tell...
Also, you modify many different variables all at once, can you please
just modify one at a time (one per patch), to make it more obvious it is
correct?
> /*
> * Default transparent print information.
> @@ -69,7 +69,7 @@
> * This defines a raw port at 9600 baud, 8 data bits, no parity,
> * 1 stop bit.
> */
> -static struct ktermios DgncDefaultTermios = {
> +static struct ktermios dgnc_default_termios = {
rename to "default_termios"?
No need to keep the driver name prefix on a static variable, right?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
