Re: [PATCH] staging: ks7010: Fix coding style errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 16, 2016 at 05:23:51PM +0200, Carlos Maiolino wrote:
> Fixes the following checkpatch.pl errors/warnings:
> 
> WARNING: please, no spaces at the start of a line
> ERROR: space prohibited after that open parenthesis '('
> ERROR: space prohibited before that close parenthesis ')'
> ERROR: space required before the open brace '{'
> ERROR: exactly one space required after that #ifdef
> WARNING: Missing a blank line after declarations
> ERROR: space prohibited after that '&' (ctx:WxW)
> WARNING: braces {} are not necessary for single statement blocks
> CHECK: No space is necessary after a cast
> Signed-off-by: Carlos Maiolino <cmaiolino28@xxxxxxxxx>

That's a lot of different things all done in the same patch.  Please
break it up into "one logical thing per patch" and resend.

Also, we need a blank line before the signed-off-by line in order for
things to work properly.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux