Re: [PATCH v2] staging: comedi: ni_mio_common: split out ao arming from ni_ao_inttrig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/10/16 15:14, Spencer E. Olson wrote:
AO device arming was previously done as a part of ni_ao_inttrig which is
called as a result of the user calling comedi_internal_trigger.  For
start_src == TRIG_EXT, this does not make very much sense since external
triggers should not conceptually need to be software triggered also.  This
patch splits out the arming functionality to allow arming to specifically
and separately be done via the CONFIG_INSN_ARM ioctl command.

In order to provide backwards compatibility, this patch also provides
automatic arming if ni_ao_inttrig is simply called.

Signed-off-by: Spencer E. Olson <olsonse@xxxxxxxxx>
---
Changes in v2:
  - reordered ni_ao_arm to avoid forward declaration
  - changed /** comments to basic block comments
  - changed "needs_arming" member of ni_private to ao_needs_arming to be clearer
    that this is only for the ao subdevice.

 drivers/staging/comedi/drivers/ni_mio_common.c | 150 ++++++++++++++++---------
 drivers/staging/comedi/drivers/ni_stc.h        |  14 +++
 2 files changed, 112 insertions(+), 52 deletions(-)

Thanks!

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux