On 10/07/2016 02:14 PM, Zach Brown wrote: > From: Josh Cartwright <josh.cartwright@xxxxxx> > > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will > create a set of led triggers for each instantiated PHY device. There is > one LED trigger per link-speed, per-phy. > > This allows for a user to configure their system to allow a set of LEDs > to represent link state changes on the phy. Seems like we are past the RFC state now, so you might want to prefix your patches with [PATCH ..] now. Also, the typical prefix used for PHYLIB changes is net: phy: foo Other than that: Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> Andrew, are you happy with this implementation? [snip] > + > +#ifdef CONFIG_LED_TRIGGER_PHY > + > +#include <linux/leds.h> > +#include <linux/phy.h> > + > +#define PHY_LINK_LED_MAX_TRIGGERS 5 > +#define PHY_LED_TRIGGER_SPEED_SUFFIX_SIZE 7 > +#define PHY_MII_BUS_ID_SIZE (20 - 3) This particular constant may be something worth moving to include/linux/phy.h eventually. -- Florian _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
