On Thu, Oct 06, 2016 at 06:52:07PM +0200, Samuele Baisi wrote: > drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:1554:5: error: > symbol 'lprocfs_wr_root_squash' redeclared with different type (originally > declared at drivers/staging/lustre/lustre/obdclass/../include/lprocfs_status.h:704) > - incompatible argument 1 (different address spaces) > > drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:1618:5: error: > symbol 'lprocfs_wr_nosquash_nids' redeclared with different type (originally > declared at drivers/staging/lustre/lustre/obdclass/../include/lprocfs_status.h:706) > - incompatible argument 1 (different address spaces) > > Added __user annotation to the header definitions arguments (which are > indeed userspace buffers). Are they really? Have you tested this? The last time this was looked at, it was a non-trivial problem... And any reason you didn't cc the lustre maintainers with this change? If you think it is correct, please resend it with the testing information and cc: them. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
