May be it is not looking better than yours but it removed 6 warning of the file which is shown by running "perl scripts/checkpatch.pl -f drivers/staging/dgnc/* | less" commend On Thu, Oct 6, 2016 at 10:51 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Wed, Oct 05, 2016 at 02:53:58PM -0700, Nadim Almas wrote: >> Fixed coding style issue >> >> Signed-off-by: Nadim Almas <nadim.902@xxxxxxxxx> >> --- >> drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------ >> 1 file changed, 12 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h >> index abddd48..65994e3 100644 >> --- a/drivers/staging/dgnc/dgnc_neo.h >> +++ b/drivers/staging/dgnc/dgnc_neo.h >> @@ -30,7 +30,8 @@ >> struct neo_uart_struct { >> u8 txrx; /* WR RHR/THR - Holding Reg */ >> u8 ier; /* WR IER - Interrupt Enable Reg */ >> - u8 isr_fcr; /* WR ISR/FCR - Interrupt Status Reg/Fifo Control Reg */ >> + u8 isr_fcr; /* WR ISR/FCR - Interrupt Status Reg/Fifo Control */ >> + /*Reg */ > > Does that really look better now than it did before? > > I don't think so :( > > sorry, > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel