On Fri, Sep 30, 2016 at 10:56 PM, Rui Miguel Silva <rmfrfs@xxxxxxxxx> wrote:
> When checking the value of delay_on to set the channel as active, it was
> checked the pointer and not the value, as it should be.
>
> Fixes: cc43368a3c ("greybus: lights: Control runtime pm suspend/resume on AP side")
>
> Signed-off-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx>
> ---
> drivers/staging/greybus/light.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
> index 2de9fc3..a631338 100644
> --- a/drivers/staging/greybus/light.c
> +++ b/drivers/staging/greybus/light.c
> @@ -484,7 +484,7 @@ static int gb_blink_set(struct led_classdev *cdev, unsigned long *delay_on,
> if (ret < 0)
> goto out_pm_put;
>
> - if (delay_on)
> + if (*delay_on)
> channel->active = true;
> else
> channel->active = false;
Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
