Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 30, 2016 at 02:49:12PM -0700, Nadim Almas wrote:
> Fixed coding style issue.
> 
> Signed-off-by: Nadim Almas <nadim.902@xxxxxxxxx>
> ---
>  drivers/staging/dgnc/dgnc_neo.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index e794056..bc15584 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -554,7 +554,8 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port)
>  		 * Rx Oruns. Exar says that an orun will NOT corrupt
>  		 * the FIFO. It will just replace the holding register
>  		 * with this new data byte. So basically just ignore this.
> -		 * Probably we should eventually have an orun stat in our driver...
> +		 * Probably we should eventually have an orun stat in our
> +		 * driver...
>  		 */
>  		ch->ch_err_overrun++;
>  	}

Why did you just fix only one of these warnings in the file?  You aren't
going to send one patch per instance of this warning in this file, are
you?  Please group it all into one.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux