On Wed, Sep 28, 2016 at 10:19:31PM +0530, Sidhant Gupta wrote:
> Fixes a comment coding style warning by adding 2 blank lines. Issue
> found by checkpatch.
>
> Signed-off-by: Sidhant Gupta <guptasidhant004@xxxxxxxxx>
> ---
>
> Changes since v2:
> * Wrapped commit comment message at 72 characters.
> * Edited word in subject line from `commit` to `comment`.
>
> drivers/staging/greybus/arche-apb-ctrl.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c
> index 70323aa..892da8e 100644
> --- a/drivers/staging/greybus/arche-apb-ctrl.c
> +++ b/drivers/staging/greybus/arche-apb-ctrl.c
> @@ -285,8 +285,10 @@ static ssize_t state_store(struct device *dev,
> if (apb->state == ARCHE_PLATFORM_STATE_FW_FLASHING)
> return count;
>
> - /* First we want to make sure we power off everything
> - * and then enter FW flashing state */
> + /*
> + * First we want to make sure we power off everything
> + * and then enter FW flashing state
> + */
> poweroff_seq(pdev);
> ret = fw_flashing_seq(pdev);
> } else {
Always run your patches through checkpatch.pl so you don't get a grumpy
maintainer telling you to run your patches through checkpatch.pl.
Moral of the story, don't make a patch that fixes a checkpatch issue,
yet adds another one :(
try again?
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
