Re: [bug report] greybus: sdio: extend sdio implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dan,
On Fri, Sep 30, 2016 at 12:55:59PM +0300, Dan Carpenter wrote:
Hello Rui Miguel Silva,

The patch 3b6ecd6de6b4: "greybus: sdio: extend sdio implementation"
from Jun 22, 2015, leads to the following static checker warning:

	drivers/staging/greybus/sdio.c:481 gb_sdio_command()
	warn: bitwise AND condition is false here

drivers/staging/greybus/sdio.c
  474          ret = gb_operation_sync(host->connection, GB_SDIO_TYPE_COMMAND,
  475                                  &request, sizeof(request), &response,
  476                                  sizeof(response));
  477          if (ret < 0)
  478                  goto out;
  479
  480          /* no response expected */
  481          if (cmd_flags & GB_SDIO_RSP_NONE)
                               ^^^^^^^^^^^^^^^^
This is zero.

Thanks for the report, I will send a patch to fix this.
Cheers,
	Rui
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux