On Thu, Sep 22, 2016 at 09:15:45PM +0300, Moshe Green wrote: > Rename CamelCased function getChipType to get_chip_type. > This issue was found by checkpatch.pl As this is a global function, can you rename it to something like "sm750_get_chip_type()"? Having a driver-specific function called get_chip_type() is not good. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
