Re: [PATCH] staging: ion: Fix checkpatch.pl coding style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 22, 2016 at 09:57:16AM +0300, Antti Keränen wrote:
> This patch fixes two coding style issues found with checkpatch.pl. Both
> of them are warnings.

Ah, then this should be two separate patches :)

Also, always use scripts/get_maintainer.pl to determine who to cc: on a
patch.

> 
> uapi/ion.h had an unaligned block comment. ion/hisilicon/hi6220_ion.c
> had unnecessary braces around a single statement block.
> 
> One warning in uapi/ion.h was left in place that wanted a typedef
> (ion_user_handle_t) to be removed.  I think the typedef makes sense so
> I left it intact.

Again, this paragraph makes no sense, don't talk about what you did not
do, why would that matter in a changelog comment?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux