On Thu, Sep 15, 2016 at 09:51:27PM +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: Don't do that! :) > > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:413:5: warning: no previous prototype for 'class_procfs_init' [-Wmissing-prototypes] > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:449:5: warning: no previous prototype for 'class_procfs_clean' [-Wmissing-prototypes] > > In fact, both functions are declared in > drivers/staging/lustre/lustre/obdclass/class_obd.c,but should be > declared in a header file, thus can be recognized in other file. > > So this patch moves the declarations into > drivers/staging/lustre/lustre/include/obd_class.h. > > Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx> > --- > drivers/staging/lustre/lustre/include/obd_class.h | 4 ++++ > drivers/staging/lustre/lustre/obdclass/class_obd.c | 2 -- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h > index 9702ad4..9965a01 100644 > --- a/drivers/staging/lustre/lustre/include/obd_class.h > +++ b/drivers/staging/lustre/lustre/include/obd_class.h > @@ -1712,6 +1712,10 @@ int class_check_uuid(struct obd_uuid *uuid, __u64 nid); > void class_init_uuidlist(void); > void class_exit_uuidlist(void); > > +/*linux-module.c*/ Here, have a ' '. make that two... thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
