Hi Laura, On 14 September 2016 at 21:03, Laura Abbott <labbott@xxxxxxxxxx> wrote: > The Ion platform code uses of_platform_device_create which has > dependencies on OF_ADDRESS. Depending on OF is not sufficient > Thanks for the patch; looks good to me. Please feel free to apply my Reviewed-by: Sumit Semwal <sumit.semwal@xxxxxxxxxx> Best, Sumit. > Building sparc64:allmodconfig ... failed > -------------- > Error log: > ... > drivers/built-in.o: In function `ion_parse_dt': > (.text+0x11aa2c): undefined reference to `of_platform_device_create' > > Add a dependency on OF_ADDRESS > > Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx> > Signed-off-by: Laura Abbott <labbott@xxxxxxxxxx> > --- > Based on next-20160914 > --- > drivers/staging/android/ion/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig > index 8a54ddc..9410554 100644 > --- a/drivers/staging/android/ion/Kconfig > +++ b/drivers/staging/android/ion/Kconfig > @@ -43,7 +43,7 @@ source "drivers/staging/android/ion/hisilicon/Kconfig" > > config ION_OF > bool "Devicetree support for Ion" > - depends on ION && OF > + depends on ION && OF_ADDRESS > help > Provides base support for defining Ion heaps in devicetree > and setting them up. Also includes functions for platforms > -- > 2.7.4 > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
