Re: [PATCH] staging: android: ion: ion_cma_heap.c fix checkpatch errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



were very trival hence did not form two patches, will not happen again

i did use the get_maintainer.pl script, Sumit Semwal
<sumit.semwal@xxxxxxxxxx> is on it, will check to see where i went
wrong

changes are in response to checkpatch.pl errors


CHECK: Please don't use multiple blank lines
#42: FILE: drivers/staging/android/ion/ion_cma_heap.c:42:
+
+

and

CHECK: Unnecessary parentheses around info->handle
#64: FILE: drivers/staging/android/ion/ion_cma_heap.c:64:
+       info->cpu_addr = dma_alloc_coherent(dev, len, &(info->handle),

On Sat, Sep 3, 2016 at 12:56 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Sat, Sep 03, 2016 at 12:26:51AM +0530, Chinmay Nivsarkar wrote:
>> Including
>> *Excess newlines
>> *Unnecessary braces
>
> Two different things usually means two different patches...
>
> And why aren't you using get_maintainer.pl to determine who to send
> these to?
>
> thanks,
>
> greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux