Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space indent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 02, 2016 at 09:04:29PM +0800, Louie Lu wrote:
> 2016-09-02 20:55 GMT+08:00 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>:
> > On Fri, Sep 02, 2016 at 06:16:10PM +0800, Louie Lu wrote:
> >> fixed comment style and space indent report from checkpatch:
> >>
> >> * WARNING: Statements should start on a tabstop
> >> * WARNING: Block comments use * on subsequent lines
> >> * WARNING: suspect code indent for conditional statements (16, 32)
> >>
> >> Signed-off-by: Louie Lu <louie.lu@xxxxxxxxxxxxxxx>
> >> ---
> >>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 37 ++++++++++++++++-----------
> >>  1 file changed, 22 insertions(+), 15 deletions(-)
> >
> > This patch adds errors :(
> >
> > Now if you want to constantly submit new checkpatch cleanups to the
> > driver, that's a good thing, but really, please use checkpatch on your
> > patches to ensure you are doing things properly.
> >
> > I'm dropping it from my patch queue.
> >
> > thanks,
> >
> > greg k-h
> 
> Hi Greg,
> 
> sorry about that I didn't know I add error to this file.
> I'll make sure this won't happen again.
> 
> And if I want to resubmit this patch 3/3, I'll only need to resend this one,
> like [PATCH 3/3 v2] this way?

I've already taken the first 2 so just send it as a single patch.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux