Re: [PATCH v2 19/21] staging: unisys: remove check for GNUC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 01, 2016 at 03:15:11PM -0400, David Kershner wrote:
> The check for GNUC is redundant and is not needed for vmcallinterface.h.
> 
> Signed-off-by: David Kershner <david.kershner@xxxxxxxxxx>
> Reviewed-by: Tim Sell <Timothy.Sell@xxxxxxxxxx>
> Reported-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/staging/unisys/visorbus/vmcallinterface.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/vmcallinterface.h b/drivers/staging/unisys/visorbus/vmcallinterface.h
> index 0e8f146..ae18996 100644
> --- a/drivers/staging/unisys/visorbus/vmcallinterface.h
> +++ b/drivers/staging/unisys/visorbus/vmcallinterface.h
> @@ -85,7 +85,6 @@ enum vmcall_monitor_interface_method_tuple { /* VMCALL identification tuples  */
>  #define VMCALL_SUCCESS 0
>  #define VMCALL_SUCCESSFUL(result)	(result == 0)
>  
> -#ifdef __GNUC__

Here's an example of something I never reported.

If I had reviewed this file, I would have found far more than just
this... :)

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux